[PATCH conductor] BZ #796797: Move Role strings out of seeds.rb to allow overrides.
Scott Seago
sseago at redhat.com
Tue Feb 28 22:30:47 UTC 2012
On 02/28/2012 12:22 PM, Jason Guiditta wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=796797
>
> Make db/seeds use i18n stuff instead of text for role defs. As a side
> effect, the UI now uses the keys and pulls the i18n trnaslation as well
> ---
> aeolus-conductor.spec.in | 3 +-
> src/app/controllers/permissions_controller.rb | 16 ++--
> src/app/views/permissions/_form.html.haml | 2 +-
> src/app/views/permissions/_permissions.html.haml | 4 +-
> src/config/locales/role_definitions/en.yml | 50 ++++++++
> ...d_view_hardware_profile_privileges_to_admins.rb | 2 +-
> src/db/seeds.rb | 127 ++++++++++----------
> src/features/permission.feature | 2 +-
> src/lib/tasks/dc_tasks.rake | 4 +-
> .../controllers/config_servers_controller_spec.rb | 4 +-
> .../provider_accounts_controller_spec.rb | 2 +-
> src/spec/factories/permission.rb | 12 +-
> 12 files changed, 139 insertions(+), 89 deletions(-)
> create mode 100644 src/config/locales/role_definitions/en.yml
>
ACK
works for me
visual ACK for the related configure patch too -- looks good, but I
didn't actually run aeolus-configure with the change, so if you did that
it's probably good to go.
Scott
More information about the aeolus-devel
mailing list