BZ 791195 - Clean up destroy_on_provider code

Tomas Sedovic tsedovic at redhat.com
Tue Feb 21 15:27:28 UTC 2012


On 02/21/2012 04:25 PM, Chris Alfonso wrote:
> On 20/02/12 17:51 -0500, Matt Wagner wrote:
>> On Mon, Feb 20, 2012 at 12:17:53PM -0500, Matt Wagner wrote:
>>> This cleans up some crazy code that obsessively retries to destroy
>>> instances on the provider after they are removed in Conductor.
>>>
>>> Resolves https://bugzilla.redhat.com/show_bug.cgi?id=791195
>>> ---
>>
>> One note about this -- I totally neglected to mention that this is
>> largely intended to work around the segfault issue. The considerable
>> number of retries in the old code was seemingly stressing GC a bit more
>> than it could take, and making it way more likely to segfault. Obviously
>> this is not the real solution to the problem, but while Jim works on
>> getting Ruby patched up, this might at least keep the wound from getting
>> bigger...
>>
>> -- Matt
> I am reviewing this patch

So was I, took it earlier today.

It's ACK from me but the more eyeballs the merrier :-)



More information about the aeolus-devel mailing list