[PATCH aeolus-image-rubygem] update aeolus-image to support both ruby 1.8 and 1.9

Mo Morsi mmorsi at redhat.com
Mon Feb 20 14:38:10 UTC 2012


>>
>> Summary: Ruby Client for interacting with Image Warehouse and Image 
>> Factory
>> Name: rubygem-aeolus-image
>> @@ -18,9 +23,6 @@ Requires: rubygems
>> Requires: rubygem(nokogiri) >= 1.4.0
>> Requires: rubygem(rest-client)
>> Requires: rubygem(oauth)
>> -Requires: rubygem(vcr)
>> -Requires: rubygem(webmock)
>> -Requires: rubygem(timecop)
>
> While I agree that these should not be requires, I have 2
> questions/concerns here:
> 1. In theory at least, you can use this library without conductor, so
> should we consider adding (this can be at a later date) a -devel
> package? Or maybe just rename conductor-devel to aeolus-devel?  Not
> sure, just thinking.
>

These packages are only for the test suite correct? In this case these 
shouldn't be Requires at all, rather BuildRequires and a %check section 
added to run the test / spec suite.

The devel package shouldn't depend on them as devel is merely a way to 
get the sources. It doesn't make sense to have a devel package for 
aeolus since its a ruby project and we get the sources w/ the main package.



> 2. The gemspec (in Rakefile) includes a development dependency on
> rspec ~> 1.3.0, so this seems likely to cause issues (and I noticed we
> dont have the above test deps listed there either, which I can add in
> the new .gemspec file update I am currently working on - not for 0.3.x
> necessarily- I can rebase my stuff to account for your changes oonce
> pushed)

Again this comes down to whether or not they really are devel 
dependencies or test deps. If they are only test deps, the gemspace / 
Gemfile should be updated to reflect that and mitigate this problem.

In any case, pushed the first four conductor patches and am looking into 
the last two

    -Mo




More information about the aeolus-devel mailing list