[PATCH aeolus-cli] bug 786220 - Scope images to Pool Family

Matt Wagner matt.wagner at redhat.com
Wed Feb 15 22:04:46 UTC 2012


On Wed, Feb 15, 2012 at 03:24:26PM -0500, Matt Wagner wrote:
> On Wed, Feb 15, 2012 at 01:51:37PM -0500, Scott Seago wrote:
> > diff --git a/lib/aeolus_cli/command/config_parser.rb b/lib/aeolus_cli/command/config_parser.rb
> > index ef64349..7bc9515 100644
> > --- a/lib/aeolus_cli/command/config_parser.rb
> > +++ b/lib/aeolus_cli/command/config_parser.rb
> > @@ -87,6 +87,9 @@ module Aeolus
> >            opts.on('-i', '--images', 'Retrieve a list of images') do
> >              @options[:subcommand] = :images
> >            end
> > +          opts.on('-E', '--environment ENVIRONMENT', 'Limit image list to environment') do |environment|
> > +            @options[:environment] =  environment
> > +          end
> >            opts.on('-b', '--builds ID', 'Retrieve the builds of an image') do |id|
> >              @options[:subcommand] = :builds
> >              @options[:id] = id
> > @@ -108,11 +111,15 @@ module Aeolus
> >            opts.on('-a', '--accounts', 'Retrieve the values available for the --account parameter') do
> >              @options[:subcommand] = :accounts
> >            end
> > +          opts.on('-c', '--environments', 'Retrieve the values available for the --environment parameter') do
> > +            @options[:subcommand] = :environments
> > +          end
> >            opts.on( '-h', '--help', 'Get usage information for this command')
> >  
> >            opts.separator ""
> >            opts.separator "Examples:"
> >            opts.separator "aeolus-image list --images                     # list available images"
> > +          opts.separator "aeolus-image list --images --envionment $env   # list available images for an environment"
> 
> Nit (while I review the rest of the code and test), but ^^^^^^^^^^^^ is
> missing an "r": "--envionment".

Other than this nit, ACK to this patch



More information about the aeolus-devel mailing list