[PATCH conductor] BZ 785094 - fixed cookie overflow and session store

Matt Wagner matt.wagner at redhat.com
Thu Feb 9 15:00:54 UTC 2012


On Thu, Feb 09, 2012 at 11:02:15AM +0100, jprovazn at redhat.com wrote:
> From: Jan Provaznik <jprovazn at redhat.com>
> 
> Because of wrong syntax in session_store initializer we used
> CookieStore instead of ActiveRecordStore.

This isn't a comment on your patch itself, but rather the session store
in general.

Were we actually overflowing the session cookie? It's allows 4 kB, so if
we were overloading that, it seems like we were likely doing something
wrong. Switching to the database store to fit more in seems like we're
just sweeping the problem under the rug.

It might just be that I'm the son of a performance engineer and that I
came here from working on a Rails site with a high number of concurrent
users, but the cookie store is the one Rails recommends using not just
because it's the easiest to set up, but also because it avoids having to
track all of this information in a database table that gets updated on
most (if not all) requests.

In any event, this is almost certainly a post-1.0 thing, but I'm curious
if there were compelling reasons to use the ActiveRecordStore beyond
allowing us to stash more data into the session?

-- Matt



More information about the aeolus-devel mailing list