[PATCH conductor 2/2] BZ 785198 - Display an error message on broken builds

Matt Wagner matt.wagner at redhat.com
Mon Feb 6 15:10:59 UTC 2012


On Mon, Feb 06, 2012 at 01:28:13PM +0100, Jan Provaznik wrote:
> On 02/01/2012 06:43 PM, Matt Wagner wrote:
> >If we have a target image but @latest_build is not set, we can infer
> >that the build has failed. We should notify the user of this fact,
> >instead of pretending everything is fine.
> >
> >Resolves https://bugzilla.redhat.com/show_bug.cgi?id=785198
> >---
> >  src/app/views/images/show.html.haml |    3 +++
> >  src/config/locales/en.yml           |    1 +
> >  2 files changed, 4 insertions(+), 0 deletions(-)
> >
> >diff --git a/src/app/views/images/show.html.haml b/src/app/views/images/show.html.haml
> >index 7e777c0..aed71bc 100644
> >--- a/src/app/views/images/show.html.haml
> >+++ b/src/app/views/images/show.html.haml
> >@@ -81,6 +81,9 @@
> >                              = t('images.show.failed_push_attempts', :count =>  failed_push_count )
> >                          - elsif pimg
> >                            = button_to "", image_provider_image_path(@image.id, pimg.id), :method =>  :delete, :class =>  'delete_image'
> >+                        - elsif timg and not @latest_build
> >+                          -# This is an apparent error condition -- the build is bad
> >+                          = t('images.show.dangling_build')
> 
> Hi Matt,
> According to your BZ comment, this bug should be related to building,
> so why display build error in push area? Shouldn't be this check done
> in upper loop (when iterating through target images)?

Hmm, this is a good point.

My thinking was that I wanted to show users/admins that a problem had
occurred, but this is probably not the place. Though I'm not really sure
what the right place *is*.

I will resend based on your feedback, and give some thought to whether
there's somewhere we should show this information. I suspect the real
"fix" is to have better messaging when a build fails in this manner, as
opposed to just writing a log entry.

-- Matt



More information about the aeolus-devel mailing list