[PATCH aeolus-cli] BZ786800 Correct VCR cassetes for delete command

Maros Zatko mzatko at redhat.com
Fri Feb 3 11:41:50 UTC 2012


On 02/02/2012 01:23 PM, Petr Blaho wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=786800
>
> This corrects content of VCR cassetes for delete image and delete target image commands
>
> There is now correct http status and body from conductor response for attempt of deleting non existent image/target image.
> ---
>   spec/command/delete_command_spec.rb                |    2 +-
>   .../delete_command/delete_image_not_found.yml      |    8 ++++----
>   .../delete_target_image_not_found.yml              |    8 ++++----
>   3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/spec/command/delete_command_spec.rb b/spec/command/delete_command_spec.rb
> index 6bafd1d..5c8d347 100644
> --- a/spec/command/delete_command_spec.rb
> +++ b/spec/command/delete_command_spec.rb
> @@ -142,4 +142,4 @@ module Aeolus
>         end
>       end
>     end
> -end
> \ No newline at end of file
> +end
> diff --git a/spec/vcr/cassettes/command/delete_command/delete_image_not_found.yml b/spec/vcr/cassettes/command/delete_command/delete_image_not_found.yml
> index 459ca77..d011746 100644
> --- a/spec/vcr/cassettes/command/delete_command/delete_image_not_found.yml
> +++ b/spec/vcr/cassettes/command/delete_command/delete_image_not_found.yml
> @@ -11,8 +11,8 @@
>         - application/xml
>     response: !ruby/struct:VCR::Response
>       status: !ruby/struct:VCR::ResponseStatus
> -      code: 500
> -      message: Internal Server Error
> +      code: 404
> +      message: Not Found
>       headers:
>         x-ua-compatible:
>         - IE=Edge,chrome=1
> @@ -32,8 +32,8 @@
>         - chunked
>       body: |
>         <error>
> -<code>ImageDeleteFailure</code>
> +<code>ImageNotFound</code>
>         <message>Could not find Image 1234</message>
>         </error>
>
> -    http_version: "1.1"
> \ No newline at end of file
> +    http_version: "1.1"
> diff --git a/spec/vcr/cassettes/command/delete_command/delete_target_image_not_found.yml b/spec/vcr/cassettes/command/delete_command/delete_target_image_not_found.yml
> index 1ec8227..0bc1621 100644
> --- a/spec/vcr/cassettes/command/delete_command/delete_target_image_not_found.yml
> +++ b/spec/vcr/cassettes/command/delete_command/delete_target_image_not_found.yml
> @@ -11,8 +11,8 @@
>         - application/xml
>     response: !ruby/struct:VCR::Response
>       status: !ruby/struct:VCR::ResponseStatus
> -      code: 500
> -      message: Internal Server Error
> +      code: 404
> +      message: Not Found
>       headers:
>         x-ua-compatible:
>         - IE=Edge,chrome=1
> @@ -32,8 +32,8 @@
>         - chunked
>       body: |
>         <error>
> -<code>TargetImageDeleteFailure</code>
> +<code>TargetImageNotFound</code>
>         <message>Could not find TargetImage 1234</message>
>         </error>
>
> -    http_version: "1.1"
> \ No newline at end of file
> +    http_version: "1.1"
test passed, looks good
ACK



More information about the aeolus-devel mailing list