[PATCH conductor] permit empty first / last names in create_admin rake task

John Eckersberg jeckersb at redhat.com
Thu Feb 2 19:08:04 UTC 2012


On Thu,  2 Feb 2012 10:33:34 -0500, Mo Morsi <mmorsi at redhat.com> wrote:
> ---
>  src/lib/tasks/dc_tasks.rake |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/lib/tasks/dc_tasks.rake b/src/lib/tasks/dc_tasks.rake
> index 28653cd..d71ae6c 100644
> --- a/src/lib/tasks/dc_tasks.rake
> +++ b/src/lib/tasks/dc_tasks.rake
> @@ -1,7 +1,7 @@
>  namespace :dc do
>    desc 'Create and register a new user'
>    task :create_user, [:login, :password, :email, :first_name, :last_name] => :environment do |t, args|
> -    unless args.login && args.email && args.password && args.first_name && args.last_name
> +    unless args.login && args.email && args.password
>        puts "Usage: rake 'dc:create_user[login,password,email,first_name,last_name]'"
>        exit(1)
>      end
> @@ -13,11 +13,14 @@ namespace :dc do
>        exit(1)
>      end
>  
> +    first_name = args.first_name.nil? ? "" : args.first_name
> +    last_name  = args.last_name.nil?  ? "" : args.last_name
> +
>      user = User.new(:login => args.login, :email => args.email,
>                      :password => args.password,
>                      :password_confirmation => args.password,
> -                    :first_name => args.first_name,
> -                    :last_name => args.last_name,
> +                    :first_name => first_name,
> +                    :last_name  => last_name,
>                      :quota => Quota.new)
>      registration = RegistrationService.new(user)
>      if registration.save
> -- 
> 1.7.6.5
> 

ACK, works as intended.



More information about the aeolus-devel mailing list