[PATCH] BZ 785196 added favicon.ico

Tomas Sedovic tsedovic at redhat.com
Thu Feb 2 12:24:59 UTC 2012


On 02/01/2012 06:54 PM, Tzu-Mainn Chen wrote:
> ---
>   src/app/views/layouts/application.html.haml |    1 +
>   src/app/views/layouts/login.html.haml       |    1 +
>   2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/app/views/layouts/application.html.haml b/src/app/views/layouts/application.html.haml
> index c5c1bf7..9d5c4ea 100644
> --- a/src/app/views/layouts/application.html.haml
> +++ b/src/app/views/layouts/application.html.haml
> @@ -3,6 +3,7 @@
>     %head
>       %meta{:charset =>  'utf-8'}/
>       %title Aeolus Conductor
> +    %link{:rel =>   'shortcut icon', :href =>  '/favicon.ico'}
>       = stylesheet_link_tag '/stylesheets/reset.css'
>       = stylesheet_link_tag '/stylesheets/960.css'
>       = stylesheet_link_tag '/stylesheets/buttons.css'
> diff --git a/src/app/views/layouts/login.html.haml b/src/app/views/layouts/login.html.haml
> index 916ad41..8846111 100644
> --- a/src/app/views/layouts/login.html.haml
> +++ b/src/app/views/layouts/login.html.haml
> @@ -3,6 +3,7 @@
>     %head
>       %meta{:charset =>  'utf-8'}/
>       %title Aeolus Conductor : Login
> +    %link{:rel =>   'shortcut icon', :href =>  '/favicon.ico'}
>       = stylesheet_link_tag '/stylesheets/reset.css'
>       = stylesheet_link_tag '/stylesheets/compiled/login.css'
>       /[if lt IE 9]

ACK in the sense that it's good to declare the favicon in the markup.

However, I don't think that's what the reported bug was about.

My impression is that they are asking for using the Red Hat logo for the 
favicon in the RH product. Which obviously should not go to the Aeolus 
upstream but to their own product repo.

So feel free to push this patch, but I doubt it will close the actual 
Bugzilla entry.

Thomas
-- 
No trees were killed to send this message, but a large number of 
electrons were terribly inconvenienced.



More information about the aeolus-devel mailing list