[PATCH conductor] BZ781579: Autoupdate for deployables#show

Scott Seago sseago at redhat.com
Wed Feb 1 16:27:34 UTC 2012


On 02/01/2012 10:59 AM, Jan Provaznik wrote:
> On 01/31/2012 04:26 PM, ifarkas at redhat.com wrote:
>> From: Imre Farkas<ifarkas at redhat.com>
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=781579
>> ---
>>   src/app/controllers/deployables_controller.rb |    8 ++++++
>>   src/app/views/deployables/show.html.haml      |   33 
>> +++++++++++++++++++++++++
>>   src/public/javascripts/backbone/models.js     |   10 +++++++
>>   src/public/javascripts/backbone/routers.js    |   19 ++++++++++++++
>>   src/public/javascripts/backbone/views.js      |   13 +++++++++-
>>   5 files changed, 82 insertions(+), 1 deletions(-)
>>
>>
>
> ACK
>
> OT note: I'm little bit scared of how much code is duplicated for 
> html/backbone views. Would be great to do deeper investigation how to 
> optimize this (in post 1.0).
>
> Jan
+1 to this.


On at least two separate occasions I fixed a bug, only to realize that 
the problem was "un-fixed" on refresh, since the auto-updated tables are 
repopulated via a completely different code path than the original 
population.

Also, the refresh code is organized in such a different way than the 
controller code that it's hard to connect it (mentally) with the related 
controller code to confirm that things are really doing the same thing.

Scott




More information about the aeolus-devel mailing list