[PATCH conductor] RM 3728 - Fix cuke upstream failure in pool.feature:183

Jason Guiditta jguiditt at redhat.com
Mon Aug 20 18:53:44 UTC 2012


On 16/08/12 16:06 -0700, Richard Su wrote:
>https://www.aeolusproject.org/redmine/issues/3728
>
>Pool.catalog_images_collection makes call out to warehouse.
>Stubbed out that method to return expected values.
>---
> src/features/step_definitions/pool_steps.rb |    6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
>diff --git a/src/features/step_definitions/pool_steps.rb b/src/features/step_definitions/pool_steps.rb
>index f575dc2..9012fe3 100644
>--- a/src/features/step_definitions/pool_steps.rb
>+++ b/src/features/step_definitions/pool_steps.rb
>@@ -141,6 +141,12 @@ end
> Given /^"([^"]*)" has catalog_entry "([^"]*)"$/ do |catalog_name, catalog_entry_name|
>   catalog = Catalog.find_by_name(catalog_name)
>   deployable = FactoryGirl.create :deployable, :name => catalog_entry_name, :catalogs => [catalog]
>+  Pool.any_instance.stub(:catalog_images_collection){
>+    entries = []
>+    entries << {:catalog => catalog.name ,:deployable => deployable.name,
>+                   :image => "name uuid", :provider_images =>[] }
>+    entries
>+  }

Perhaps I am missing something obvious, but for the ablove method
body, why would it not just be collapsed into:

Pool.any_instance.stub(:catalog_images_collection) do
   [{:catalog => catalog.name ,:deployable => deployable.name,
     :image => "name uuid", :provider_images =>[]]
end

-j
> end
>
> Given /^"([^"]*)" has catalog_entry with parameters "([^"]*)"$/ do |catalog_name, catalog_entry_name|
>-- 
>1.7.7.6
>



More information about the aeolus-devel mailing list