[PATCH conductor 0/1] Fix silly typo

Tzu-Mainn Chen tzumainn at redhat.com
Wed Aug 15 17:06:46 UTC 2012


ACK'd and pushed to master.

Mainn

----- Original Message -----
> From: "Matt Wagner" <matt.wagner at redhat.com>
> To: aeolus-devel at lists.fedorahosted.org
> Sent: Wednesday, August 15, 2012 11:36:45 AM
> Subject: [PATCH conductor 0/1] Fix silly typo
> 
> 
> I sent a patch yesterday that got approved. It turns out to contain a
> typo.
> 
> This was breaking some tests, like
> ./spec/controllers/pools_controller_spec.rb:111
> (see https://www.aeolusproject.org/redmine/issues/3700)
> 
> However, it seems like the root cause of that failure has been
> corrected, so the test now passes. So it's not immediately
> obvious how to see the before-and-after here, and it seems
> silly to write a "There should not be a random syntax error
> in the middle of this method" test, especially where the error
> is obvious (the correct usage was a couple words over on the
> same line).
> 
> -- Matt
> 



More information about the aeolus-devel mailing list