Richard W.M. Jones wrote:
John Summerfield wrote:
virtinst--devel/virtinst/ParaVirtGuest.py: cmd = ["/usr/bin/virsh", "console", "%s" %(self.domain.ID(),)]
Surely, the location of executable components should not be hard-coded in the source tree. I could live with it, grudgingly, if it was set at configure time.
Agreed -- this is simply a bug in virt-manager.
There are a few other places the virt* programs have fixed ideas about where stuff must be: [summer@potoroo virt]$ find * -type f -exec grep -HE '/usr/(|s)bin' {} ; | grep -Ev '/usr/bin/(perl|python)' Binary file virt-manager--devel/.hg/store/data/src/gnome-virt-manager.in.i matches virt-manager--devel/autobuild.sh:if [ -f /usr/bin/rpmbuild ]; then virt-manager--devel/src/virt-manager.py.in: elif os.path.exists("/usr/bin/qemu"): virt-viewer--devel/autobuild.sh:if [ -f /usr/bin/rpmbuild ]; then virt-viewer--devel/virt-viewer.spec.in:BuildRequires: /usr/bin/pod2man virtinst--devel/tests/boot-paravirt-disk-file.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/tests/boot-paravirt-many-disks.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/tests/boot-paravirt-disk-drv-tap-qcow.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/tests/boot-paravirt-disk-drv-phy.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/tests/boot-paravirt-disk-drv-file.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/tests/boot-paravirt-disk-drv-tap.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/tests/capabilities-qemu.xml: <emulator>/usr/bin/qemu-system-x86_64</emulator> virtinst--devel/tests/capabilities-qemu.xml: <emulator>/usr/bin/qemu</emulator> virtinst--devel/tests/capabilities-qemu.xml: <emulator>/usr/bin/qemu-system-mips</emulator> virtinst--devel/tests/capabilities-qemu.xml: <emulator>/usr/bin/qemu-system-mipsel</emulator> virtinst--devel/tests/capabilities-qemu.xml: <emulator>/usr/bin/qemu-system-sparc</emulator> virtinst--devel/tests/capabilities-qemu.xml: <emulator>/usr/bin/qemu-system-ppc</emulator> virtinst--devel/tests/boot-paravirt-disk-block.xml: <bootloader>/usr/bin/pygrub</bootloader> virtinst--devel/autobuild.sh:if [ -f /usr/bin/rpmbuild ]; then virtinst--devel/virtinst/util.py: elif os.path.exists("/usr/bin/qemu"): virtinst--devel/virtinst/util.py: for dir in ['', '/sbin/', '/usr/sbin']: virtinst--devel/virtinst/ImageManager.py: osblob += " <bootloader>/usr/bin/pygrub</bootloader>" virtinst--devel/virtinst/ParaVirtGuest.py: cmd = ["/usr/bin/virsh", "console", "%s" %(self.domain.ID(),)] virtinst--devel/virtinst/DistroManager.py: osblob += "<bootloader>/usr/bin/pygrub</bootloader>" virtinst--devel/virtinst/DistroManager.py: osblob += "<bootloader>/usr/bin/pygrub</bootloader>" virtinst--devel/virt-install: args = ["/usr/bin/virt-viewer"] virtinst--devel/virt-install: args = ["/usr/bin/virsh"] virtinst--devel/ChangeLog: 'distro' Traceback (most recent call last): File "/usr/bin/virt- virtinst--devel/ChangeLog: install", line 647, in <module> main() File "/usr/bin/virt- virtinst--devel/ChangeLog: Move virt-install & virt-clone to /usr/bin instead of sbin since [summer@potoroo virt]$