Dan Kenigsberg has uploaded a new change for review.
Change subject: tc: avoid adding non-existing devices to filter ......................................................................
tc: avoid adding non-existing devices to filter
When a mirroring target dies, its tap device are removed. On `tc filter show`, the tap device name is replaced with a string like `if17`, which is not a name of an existing device.
This patch is somewhat racy, as another qemu may die just before the new filter is set.
Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/tc.py 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/7631/1
diff --git a/vdsm/tc.py b/vdsm/tc.py index 47a7b96..d363d35 100644 --- a/vdsm/tc.py +++ b/vdsm/tc.py @@ -20,6 +20,8 @@
from collections import namedtuple
+import ethtool + import storage.misc from vdsm.constants import EXT_TC, EXT_IFCONFIG
@@ -55,6 +57,7 @@
acts = set(filt.actions) acts.discard(MirredAction(target)) + acts.update(ethtool.get_devices())
if acts: filt = Filter(prio=filt.prio, handle=filt.handle, actions=acts)
-- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tc: avoid adding non-existing devices to filter ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/781/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Antoni Segura Puimedon has posted comments on this change.
Change subject: tc: avoid adding non-existing devices to filter ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
Agreed. It removes part of the risk.
-- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Meni Yakove has posted comments on this change.
Change subject: tc: avoid adding non-existing devices to filter ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: tc: avoid adding non-existing devices to filter ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tc: avoid adding non-existing devices to filter ......................................................................
tc: avoid adding non-existing devices to filter
When a mirroring target dies, its tap device are removed. On `tc filter show`, the tap device name is replaced with a string like `if17`, which is not a name of an existing device.
This patch is somewhat racy, as another qemu may die just before the new filter is set.
Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/tc.py 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: Meni Yakove: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org