Federico Simoncelli has uploaded a new change for review.
Change subject: Internal volumes must be RO in domain version 2 ......................................................................
Internal volumes must be RO in domain version 2
Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 --- M vdsm/storage/volume.py 1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/2786/1 -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Internal volumes must be RO in domain version 2 ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Do not commit this until we have domain version 3 and the upgrade.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Internal volumes must be RO in domain version 2 ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 460: if sdCache.produce(self.sdUUID).getVersion() <= 2: Use the new hasVolumeLeases().
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 4: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): I don't like the placement of this logic but with the current design I find it hard to think of anything better.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Eduardo has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): Do not produce the domain again please. Pass a setRO flag instead. There are 3 callers: 2 in image mod: _baseRawVolumeMerge() and _finalizeDestinationImage() There you already has the SD object and can check domain 3 there and pass the parameter.
The 3rd call is from the Volume.clone() function. This call should be removed and setInternal() called from the [Block,File]Volume.create() where the domain object is already produced, check domain 3, and pass the setRO parameter.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): My opinion is that keeping the interface clean is more important then evading produce calls. Unless this causes a real performance hit. I don't see why we should make the interface more complicated
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Eduardo has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): There are _real_performance hits due the fact the metadata is accessed most of the times. In addition the same metadata is read many times in a row by the same thread. But this is no the reason. This is adding another reversed dependency like image -> volume -> SD and we need to remove this since is more correct to do it at the SD level. This change make this more difficult to reach. A bool parameter, is not nice, but is not a so "complicated" interface.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 9: I would prefer that you didn't submit this
(4 inline comments)
.................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): This has absolutely nothing to do with volumeLeases. This just has to do with it being incompatible with live snapshots (internal snapshot might still be in use by VM on non-spm host) Also, once we no longer support v2 domains it would be difficult to know that this piece of code is no longer relevant.
Line 517: self.setrw(rw=True) this line would also be irrelevant in v3 domains, no?
Line 520: # Look at setInternal for more information on this this looks exactly like setInternal, why not call it and have only 1 place that does this?
Line 521: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): again has nothing to do with volume leases
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 11: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 11: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 12: Looks good to me, but someone else must approve
(1 inline comment)
Please fix the typo - other than that, +1.
.................................................... File vdsm/storage/volume.py Line 436: # permissions to read-only because it would interfere with the live Eg->E.g., it's an acronym.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 466: # permissions to read-only because it would interfere with the live Eg->E.g.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): shouldn't this method be annotated as deprecated instead of having 'legacy' in the name?
also, why not have a decorator for the version logic? (only run if x < whatever)
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (2 inline comments)
.................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): The "deprecated" decorator is available only to hsm.py at the moment. Obviously it is possible to move it somewhere else and make it widely available but the legacy checks might be a little bit tricky to define if you want to make it reusable. For example you need a way to express where to get the data (sdUUID) and add the code that is capable to extract such information.
Line 466: # permissions to read-only because it would interfere with the live I don't mind changing it but "eg" is listed as alternative form.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): To avoid another review cycle can you suggest a name for the method? Removing the _legacy prefix makes it _setRW which is too much generic (we already have several setrw methods). I was thinking of _setTypeRW (since it has to do with the volume type). Please add as many detail as you can to avoid another iteration.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): if you're adding the decorator then why not put it directly on setrw? then you don't need this function at all
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): Because we use it also in setShared (it's still relevant there I suppose).
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 466: # permissions to read-only because it would interfere with the live According to wiktionary you are correct. I take it back.
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Allon Mureinik has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 16: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Maor Lipchuk has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/storage/volume.py Line 475: if int(sdCache.produce(self.sdUUID).getVersion()) < 3: Consider maybe using a constant for V3
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Haim Ateya has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 17: Verified
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 17: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Internal volumes must be RW in domain version 3
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 --- M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/hsm.py M vdsm/storage/misc.py M vdsm/storage/volume.py 5 files changed, 38 insertions(+), 18 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Haim Ateya: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 17:
I do not see Eduardo jumping with joy now :-(
-- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org