Dan Kenigsberg has uploaded a new change for review.
Change subject: configNetTests: re-grow the stub ......................................................................
configNetTests: re-grow the stub
I've created stubs to limit my unittest, but forgot to restore the changed function and variables. This patch fixes this regression.
Change-Id: I72aeed1c426eb7a91d76ae3468580333c29fdd74 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/configNetworkTests.py 1 file changed, 31 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/5967/1 -- To view, visit http://gerrit.ovirt.org/5967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I72aeed1c426eb7a91d76ae3468580333c29fdd74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: configNetTests: re-grow the stub ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I72aeed1c426eb7a91d76ae3468580333c29fdd74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configNetTests: re-grow the stub ......................................................................
configNetTests: re-grow the stub
I've created stubs to limit my unittest, but forgot to restore the changed function and variables. This patch fixes this regression.
Change-Id: I72aeed1c426eb7a91d76ae3468580333c29fdd74 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/configNetworkTests.py 1 file changed, 31 insertions(+), 23 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/5967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I72aeed1c426eb7a91d76ae3468580333c29fdd74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: configNetTests: re-grow the stub ......................................................................
Patch Set 1: Verified; Looks good to me, approved
Thanks for acking. I hate regressions, and I hate them even more when I'm responsible.
-- To view, visit http://gerrit.ovirt.org/5967 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I72aeed1c426eb7a91d76ae3468580333c29fdd74 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org