From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Embed vdsm-restore-net-config into vdsm.network
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/76085/2/lib/vdsm/supervdsm_api/network.py
File lib/vdsm/supervdsm_api/network.py:
Line 23: from vdsm.sysctl import set_rp_filter_loose, set_rp_filter_strict
Line 24: from vdsm.network.api import (setSafeNetworkConfig, setupNetworks,
Line 25: change_numvfs, network_caps, ovs_bridge,
Line 26: add_sourceroute, remove_sourceroute)
Line 27: from vdsm.network.restore_net_config import restore
why you are introducing a new entry point, outside vdsm.network.api?
Line 28: from vdsm.network.tc import setPortMirroring, unsetPortMirroring
Line 29:
Line 30:
Line 31: @expose
https://gerrit.ovirt.org/#/c/76085/2/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
PS2, Line 59: '/etc/vdsm/svdsm.logger.conf'
please replace (in another patch) with vdsm.supervdsm_server.LOG_CONF_PATH
PS2, Line 62: stdout
please replace with stderr
--
To view, visit
https://gerrit.ovirt.org/76085
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3d0ca93179aeb98a89f68265e368d13924f21e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes