Hello Wenchao Xia,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: pep8 clean vdsm/storage/hba.py ......................................................................
pep8 clean vdsm/storage/hba.py
Change-Id: I0b77068d193609becdcf79093814053719e05bcb Signed-off-by: wenchao xia xiawenc@linux.vnet.ibm.com --- M Makefile.am M vdsm/storage/hba.py 2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/4793/1 -- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: pep8 clean vdsm/storage/hba.py ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8 clean vdsm/storage/hba.py ......................................................................
Patch Set 1: Verified
The patch passes tests in vdsm. And I compare the old file and new file with a tool named pydiff.py. It can print logic changes of Python scripts. Luckily, the tool says there is no logic change in the file. The tool is at: https://github.com/edwardbadboy/pydiff
-- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Shu Ming has posted comments on this change.
Change subject: Make vdsm/storage/hba.py PEP8 clean ......................................................................
Patch Set 3: Verified
-- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/storage/hba.py PEP8 clean ......................................................................
Patch Set 3: Verified
The patch passes tests in vdsm and pydiff reports no differences found in code logic.
-- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Make vdsm/storage/hba.py PEP8 clean ......................................................................
Patch Set 4: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make vdsm/storage/hba.py PEP8 clean ......................................................................
Make vdsm/storage/hba.py PEP8 clean
Change-Id: I0b77068d193609becdcf79093814053719e05bcb Signed-off-by: wenchao xia xiawenc@linux.vnet.ibm.com --- M Makefile.am M vdsm/storage/hba.py 2 files changed, 8 insertions(+), 5 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4793 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I0b77068d193609becdcf79093814053719e05bcb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org