Adam Litke has uploaded a new change for review.
Change subject: build: Add an option to skip unit tests ......................................................................
build: Add an option to skip unit tests
During development it is common to rebuid vdsm many times. In that case it is very time-consuming to run the tests each time. Provide a method to skip testing during a build.
make SKIPTESTS=1 rpm
Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Signed-off-by: Adam Litke agl@us.ibm.com --- M tests/Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/3906/1 -- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1:
is it any better than
make NOSE_EXCLUDE=.* rpm ?
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
ShaoHe Feng has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1:
Dan, I suppose it has the same effect. Was not aware of this trick with nose.
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com
Wenchao Xia has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1:
It have the same effect, but I think we need document it to let user know. Maybe add a line in README or added an option in Makefile like "make rpm_no_ut".
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1: I would prefer that you didn't submit this
adding documentation is a good idea 95% of the time, so please do. You can update http://www.ovirt.org/wiki/Features/Nose_tests or add a README, or a even a hint to `make check` saying something like:
"If you are short in time and do not care about code quality, avoid this step with NOSE_EXCLUDE=.*"
(I do not mind little jokes in Makefiles)
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Wenchao Xia has posted comments on this change.
Change subject: build: Add an option to skip unit tests ......................................................................
Patch Set 1:
give a hint in local-check seems good, the user without knowledge of NoseTest would know he have an option.
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: doc: Add informational message for skipping tests ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: doc: Add informational message for skipping tests ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: doc: Add informational message for skipping tests ......................................................................
doc: Add informational message for skipping tests
Signed-off-by: Adam Litke agl@us.ibm.com Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f --- M tests/Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Adam Litke: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3906 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I0714099b3d388a4081896cb5b76fca613067e28f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org