From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: python3: avoid decoding errors ......................................................................
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/78044/10/tests/vmfakecon.py File tests/vmfakecon.py:
Line 139: dir_name, 'devices', 'data', name + '.xml') Line 140: Line 141: device_xml = None Line 142: try: Line 143: with open(xml_path, 'rb') as device_xml_file: moving to io.open is the noble step Line 144: device_xml = device_xml_file.read() Line 145: except IOError as e: Line 146: if e.errno == errno.ENOENT: Line 147: # The code in VirNodeDeviceStub will consider this device
PS10, Line 158: 'ascii' either use 'utf8' to allow future use of Czech or Hebrew
vdsm-patches@lists.fedorahosted.org