Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
bootstrap: introduce bootstrap interface version
Bootstrap interface version is a method of supporting multiple engine versions within bootstrap code.
The vdsm-bootstrap code is separate package which can be upgraded without engine upgrade. Engine is also upgrade protected, so force update upon vdsm-bootstrap upgrade is difficult.
As the vdsm-bootstrap is separate package from engine, but depends heavily on engine interaction, and since it may be updated, it should support backward compatibility with different versions of engines.
If changes are relatively small, a bootstrap interface version may come in handy so no script duplication is required.
Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vds_bootstrap/vds_bootstrap.py M vds_bootstrap/vds_bootstrap_complete.py M vdsm_reg/deployUtil.py.in 3 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/7092/1 -- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/patch_vdms_manager/10/
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdms_manager/10/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
few comments.
.................................................... File vds_bootstrap/vds_bootstrap_complete.py Line 25: import logging Line 26: import tempfile Line 27: from time import strftime Line 28: Line 29: bootstrap_interface_version = 1 constant should use capital letters. Line 30: Line 31: # set logging before deployUtil is first used Line 32: try: Line 33: LOGDIR=os.environ["OVIRT_LOGDIR"]
.................................................... File vds_bootstrap/vds_bootstrap.py Line 51: import socket Line 52: import tempfile Line 53: from time import strftime Line 54: Line 55: bootstrap_interface_version = 1 constant should use capital letters: http://www.python.org/dev/peps/pep-0008/#constants
Can you please add a comment about this constant? What's difference between 1 and others values? Line 56: Line 57: # set logging before deployUtil is first used Line 58: try: Line 59: LOGDIR=os.environ["OVIRT_LOGDIR"]
Line 946: -f <firewall_rules_file> -- override firewall rules. Line 947: -V - don't install virtualization service Line 948: -g - install gluster service Line 949: obsolete options: Line 950: -r <rev_num> can you please also document the option -v ? Line 951: """ Line 952: try: Line 953: global bootstrap_interface_version Line 954: rev_num = None
.................................................... File vdsm_reg/deployUtil.py.in Line 92: "\n":' ', Line 93: "'":'~' Line 94: } Line 95: Line 96: bootstrap_interface_version = 1 the same here Line 97: Line 98: def isOvirt(): Line 99: """ Line 100: This function checks if current machine runs ovirt platform.
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 2: (2 inline comments)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 51: import socket Line 52: import tempfile Line 53: from time import strftime Line 54: Line 55: bootstrap_interface_version = 1 This is not constant, it is global.
It accepts the bootstrap interface version so script may behave as engine expects. This is our backward compatibility hint for now... until I rewrite a whole new process. Line 56: Line 57: # set logging before deployUtil is first used Line 58: try: Line 59: LOGDIR=os.environ["OVIRT_LOGDIR"]
Line 946: -f <firewall_rules_file> -- override firewall rules. Line 947: -V - don't install virtualization service Line 948: -g - install gluster service Line 949: obsolete options: Line 950: -r <rev_num> Done Line 951: """ Line 952: try: Line 953: global bootstrap_interface_version Line 954: rev_num = None
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3:
Added documentation of -v at vds_boostrap.py
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/429/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 51: import socket Line 52: import tempfile Line 53: from time import strftime Line 54: Line 55: bootstrap_interface_version = 1 I still think we need a comment here explaining what's bootstrap_interface_version and it's value, even if you are about to rewrite this code. Line 56: Line 57: # set logging before deployUtil is first used Line 58: try: Line 59: LOGDIR=os.environ["OVIRT_LOGDIR"]
Line 940: """ Line 941: Usage: vds_bootstrap.py [options] <url> <subject> <random_num> Line 942: Line 943: options: Line 944: -v <bootstrap inteface version> - default 1 default 1 doesn't say too much about this option... Line 945: -O <organizationName> Line 946: -t <systemTime> Line 947: -f <firewall_rules_file> -- override firewall rules. Line 948: -V - don't install virtualization service
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eyal Edri eedri@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3: (2 inline comments)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 51: import socket Line 52: import tempfile Line 53: from time import strftime Line 54: Line 55: bootstrap_interface_version = 1 I will add a note, but provided the next comment, I will wait for the usage statement and take it as is.
Thanks. Line 56: Line 57: # set logging before deployUtil is first used Line 58: try: Line 59: LOGDIR=os.environ["OVIRT_LOGDIR"]
Line 940: """ Line 941: Usage: vds_bootstrap.py [options] <url> <subject> <random_num> Line 942: Line 943: options: Line 944: -v <bootstrap inteface version> - default 1 Douglas, this is not a script for user to execute, not sure what description you mean.
I will happily integrate whatever statement you would like to add in this regard, the commit message and the previous discussion provides all the information you need to suggest something useful to write here.
Thanks. Line 945: -O <organizationName> Line 946: -t <systemTime> Line 947: -f <firewall_rules_file> -- override firewall rules. Line 948: -V - don't install virtualization service
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 940: """ Line 941: Usage: vds_bootstrap.py [options] <url> <subject> <random_num> Line 942: Line 943: options: Line 944: -v <bootstrap inteface version> - default 1 I meant, can you please explain in the code what's the meaning of 'bootstrap inteface version' and 'default 1'? Example: Can we have 1 or 2 as default or only 1? What's 1?
We might know now, few months ahead might be difficult to guess looking the code. However, Dan might have a different opinion.
Thanks! Line 945: -O <organizationName> Line 946: -t <systemTime> Line 947: -f <firewall_rules_file> -- override firewall rules. Line 948: -V - don't install virtualization service
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 940: """ Line 941: Usage: vds_bootstrap.py [options] <url> <subject> <random_num> Line 942: Line 943: options: Line 944: -v <bootstrap inteface version> - default 1 I understand, please suggest phrasing... we have the commit message as a base, what exactly do you want to go into comment and what into usage.
We can have 1 for all 3.1 pre-beta1 (including) and 2 for 3.1 post beta1. I guess we have more in future unless we perform revolution. Line 945: -O <organizationName> Line 946: -t <systemTime> Line 947: -f <firewall_rules_file> -- override firewall rules. Line 948: -V - don't install virtualization service
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vds_bootstrap/vds_bootstrap.py Line 50: import ConfigParser Line 51: import socket Line 52: import tempfile Line 53: from time import strftime Line 54: What about:
# bootstrap_interface_version is ... # possible values: # 1 - ... # 2 - ... # Additional comments? Line 55: bootstrap_interface_version = 1 Line 56: Line 57: # set logging before deployUtil is first used Line 58: try:
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 4:
added notes for bootstrap interface protocol variable, I think this is redundant.
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 5: Verified
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 5: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 5: I would prefer that you didn't submit this
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 5:
Why?
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/483/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 6: Verified
Rebase.
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 6:
ahhh, where's my comment?!
I asked why are you having multiple variables carrying the same thing - one in the script, and one in the deployUtil module.
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 6:
why are you having multiple variables carrying the same thing - one in the script, and one in the deployUtil module.
Because I wanted to separate this to allow separate the scripts if we like.
I don't care at this stage to use only the deployUtils if it makes you more comfortable.
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 6: I would prefer that you didn't submit this
indeed, data duplication make me feel uncomfortable.
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 7:
Anything to make you happy :)
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 7: Verified
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/501/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
Patch Set 7: Looks good to me, approved
not "happy". just more comfortable. ;-)
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bootstrap: introduce bootstrap interface version ......................................................................
bootstrap: introduce bootstrap interface version
Bootstrap interface version is a method of supporting multiple engine versions within bootstrap code.
The vdsm-bootstrap code is separate package which can be upgraded without engine upgrade. Engine is also upgrade protected, so force update upon vdsm-bootstrap upgrade is difficult.
As the vdsm-bootstrap is separate package from engine, but depends heavily on engine interaction, and since it may be updated, it should support backward compatibility with different versions of engines.
If changes are relatively small, a bootstrap interface version may come in handy so no script duplication is required.
Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vds_bootstrap/vds_bootstrap.py M vds_bootstrap/vds_bootstrap_complete.py M vdsm_reg/deployUtil.py.in 3 files changed, 21 insertions(+), 3 deletions(-)
Approvals: Alon Bar-Lev: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org