Federico Simoncelli has posted comments on this change.
Change subject: Add the formatConverter for Storage Domain V3
......................................................................
Patch Set 17: (10 inline comments)
....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 41: newMetadata._dict.update(metadata)
Because we changed the DMDK_VERSION value. Is there a different (safe) way of doing this
that I don't see at the moment?
Line 93: type(vol).newVolumeLease(metaId, vol.sdUUID, vol.volUUID)
If sanlock.init_resource fails it throws an exception: sanlock.SanlockException
Line 97: metaVolSize = int(vol.getMetaParam(volume.SIZE))
Done
Line 123: # XXX: The only reason to prepare the image is to verify the volume
http://stackoverflow.com/questions/1452934/what-is-the-meaning-of-xxx
Line 128: # The analyzed scenario are:
Done
Line 130: # This is safe because the prepare is superflous and the
Done
Line 143: # to read the image virtual size) and it can be restarted
Yes I remember we discussed this. I'm not sure if I can try to do something reliable
at the moment (it requires testing). I'll try to postpone this.
Line 174: newClusterLock.release()
No time for this.
Line 183: newClusterLock.releaseHostId(hostId)
No time for this.
Line 191: domain._clusterLock.release()
I'll add a comment on this.
--
To view, visit
http://gerrit.ovirt.org/3841
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74185a4521fb88444c88de628a18c2210359af29
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>