Dan Kenigsberg has posted comments on this change.
Change subject: ISCSI Subsystem refactoring
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
minor comments, serious review requires true knowledge of iscsi.
....................................................
File vdsm/storage/hsm.py
Line 1978: "target": {
please convince us that this change is backward compatible!
Line 2027: # TODO: Handle possible CID collision
does your refactoring handle these todos? if so, remove them.
....................................................
File vdsm/storage/iscsiadm.py
Line 50: #FIXME: can be optimized by checking /var/lib/iscsi/ifaces
that's mentioned already inside the function
Line 127: rc, out, err = _runCmd(["-m", "discoverydb",
"-t", discoveryType, "-I", iface, "-p", portal,
"-n", key, "-v", value, "--op=update"], hideValue)
be a sport, use short lines
....................................................
File vdsm/storage/iscsi.py
Line 2: # Copyright 2009-2011 Red Hat, Inc.
happy new year
--
To view, visit
http://gerrit.ovirt.org/1607
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>