Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: survive missing ntpq ......................................................................
bootstrap: survive missing ntpq
Minimal fedora installation does not have ntpq.
Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/7597/1
diff --git a/vdsm_reg/deployUtil.py.in b/vdsm_reg/deployUtil.py.in index fc7df29..028fef5 100644 --- a/vdsm_reg/deployUtil.py.in +++ b/vdsm_reg/deployUtil.py.in @@ -691,7 +691,9 @@ import time fReturn = True
- out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) + out = "" + if os.path.exists(EX_NTPQ): + out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) if 'clock_sync' in out: logging.debug("setHostTime: Time is synchronised to NTP server.") else:
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1: I would prefer that you didn't submit this
The vdsm.spec requires ntp, which provides ntpq. Any failure during vdsm installation?
-1 = since I have a question
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1:
bootstrap is something completely different.
It is sent from the engine pre to any other operation.
As time set is done as soon as we can (to be able to sync time with smallest delta), nothing is installed yet.
There are other abnormalities that I will fix when rewrite, for example, currently we discover tools at build machine, injecting full path for tools that may reside on different location where bootstrap actually runs.
BTW: you guys abuse the -1... remember that there is also 0. Use -1 when you actually don't agree with <something>.
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/764/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Hi,
I see the point and agree with your comments. Indeed, you moved the oDeploy.setSystemTime() in one of your previous patches so will be very early in the deploy.. +1 now
About your -1 comment, agreed, 0 is ok for me.
Thanks Douglas
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 693: Line 694: out = "" Line 695: if os.path.exists(EX_NTPQ): Line 696: out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) Line 697: if 'clock_sync' in out: I think a slightly safer (works for other failures to run ntpq) and even smaller(!) way would be
if out and 'clock_sync' in out: Line 698: logging.debug("setHostTime: Time is synchronised to NTP server.") Line 699: else: Line 700: try: Line 701: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S')
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 693: Line 694: out = "" Line 695: if os.path.exists(EX_NTPQ): Line 696: out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) Line 697: if 'clock_sync' in out: Done Line 698: logging.debug("setHostTime: Time is synchronised to NTP server.") Line 699: else: Line 700: try: Line 701: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S')
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/772/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) Line 689: if out and 'clock_sync' in out: I was not clear, I'm afraid. I was saying that checking for existence is not really needed. On error, out is set to None, and that's all that needs to be added. Line 690: logging.debug("setHostTime: Time is synchronised to NTP server.") Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S')
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3: No score
Indeed. No need to the 1st "if".
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) Line 689: if out and 'clock_sync' in out: I got an exception... but will try again. Line 690: logging.debug("setHostTime: Time is synchronised to NTP server.") Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S')
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 4: Verified
OK, the _logExec caches the exception.
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/777/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Amador Pahim has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Barak Azulay has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 4: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 4: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bootstrap: survive missing ntpq ......................................................................
bootstrap: survive missing ntpq
Minimal fedora installation does not have ntpq.
Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vdsm_reg/deployUtil.py.in 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Alon Bar-Lev: Verified Douglas Schilling Landgraf: Looks good to me, but someone else must approve Amador Pahim: Looks good to me, but someone else must approve Barak Azulay: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: survive missing ntpq ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm_reg/deployUtil.py.in Line 685: Line 686: out = None Line 687: if os.path.exists(EX_NTPQ): Line 688: out, err, rc = _logExec([EX_NTPQ, "-c", "rv"]) Line 689: if out and 'clock_sync' in out: you are not at fault here. _logExec() has cruel and unusual semantics.. Line 690: logging.debug("setHostTime: Time is synchronised to NTP server.") Line 691: else: Line 692: try: Line 693: ttp = time.strptime(VDCTime, '%Y-%m-%dT%H:%M:%S')
-- To view, visit http://gerrit.ovirt.org/7597 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Amador Pahim apahim@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org