Zhou Zheng Sheng has posted comments on this change.
Change subject: Fixing pep8 in vdsm/storage/fileVolume.py
......................................................................
Patch Set 2: (1 inline comment)
Please refer to the inline comment.
....................................................
File vdsm/storage/fileVolume.py
Line 422: getImage() == imgUUID):
Actually, I would prefer to put the "." at the beginning of the line, not at the
end of the line. Because I think "." means to select a member, so if
"." is put at the beginning of the line followed by a function call, we will
know the function call is a member function call. If the "." is put at the end
of the line, and the member function call is put to the next line, the function call will
appears like a normal function call. So I suggest:
if (sdCache.produce(sdUUID)
.produceVolume(imgUUID, volid)
.getImage() == imgUUID):
There is no PEP 8 rule for this case, it's my personal advice. Which do you prefer?
--
To view, visit
http://gerrit.ovirt.org/4541
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1ce2aef9ac4be974529ecaf76d5dc5a578d92d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>