From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: handle handshake errors ......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/79668/7/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py:
Line 254: elif err.args[0] == ssl.SSL_ERROR_WANT_WRITE: Line 255: self.want_write = True Line 256: else: Line 257: dispatcher.close() Line 258: except socket.error: silently ignoring these two errors is counter intuitive. Maybe you can add a comment for future developers? Line 259: dispatcher.close() Line 260: else: Line 261: self.want_read = self.want_write = True Line 262: self._is_handshaking = False
vdsm-patches@lists.fedorahosted.org