Lei Li has uploaded a new change for review.
Change subject: Pass iface without nic interface ......................................................................
Pass iface without nic interface
When add a network without nic, unexpected error showed as "IndexError: tuple index out of range".
vdsm should pass iface with nic as None to meet the topology in-host only. Also to keep consistence to other interface that the default value of iface is None.
Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Signed-off-by: Lei Li lilei@linux.vnet.ibm.com --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/4167/1 -- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Pass iface without nic interface ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Pass iface without nic interface ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Pass iface without nic interface ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Shahar Havivi has posted comments on this change.
Change subject: Pass iface without nic interface ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Lei Li has posted comments on this change.
Change subject: Pass iface without nic interface ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Pass iface without nic interface ......................................................................
Pass iface without nic interface
When add a network without nic, unexpected error showed as "IndexError: tuple index out of range".
vdsm should pass iface with nic as None to meet the topology in-host only. Also to keep consistence to other interface that the default value of iface is None.
Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Signed-off-by: Lei Li lilei@linux.vnet.ibm.com --- M vdsm/configNetwork.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Lei Li: Verified Douglas Schilling Landgraf: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, but someone else must approve Igor Lvovsky: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4167 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I9b0e9d17370717594ccf8d43b9f16c61dd80c570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Lei Li lilei@linux.vnet.ibm.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com
vdsm-patches@lists.fedorahosted.org