Yaniv Bronhaim has submitted this change and it was merged.
Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test
......................................................................
BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test
testGetIfaceByIP fails on machines that have an updated
ethtool, because the test now iterates on devices
that were previously not iterated over.
The test now ignores IPv6 link-local addresses (Which may
be shared with several network devices), and checks
if the device has an ipv4 address configured before
checking it.
Change-Id: Iee4757958ea5554043c6dc7169a8df05b1887687
Signed-off-by: Assaf Muller <amuller(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/22968
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Tested-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M tests/netinfoTests.py
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Yaniv Bronhaim: Verified; Looks good to me, approved
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/22968
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee4757958ea5554043c6dc7169a8df05b1887687
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server