Dan Kenigsberg has uploaded a new change for review.
Change subject: momTest: improve test's error reports ......................................................................
momTest: improve test's error reports
The test is skipped if MOM is not installed on host. Also, the returned value of the setMOMPolicy call is checked.
MOMTest.testKSM still fails on my host, but at least I can tell when in the test process it has happened.
Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/functional/momTests.py 1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/7571/1
diff --git a/tests/functional/momTests.py b/tests/functional/momTests.py index f5110a2..584468a 100644 --- a/tests/functional/momTests.py +++ b/tests/functional/momTests.py @@ -17,12 +17,19 @@ # # Refer to the README and COPYING files for full details of the license # +import imp import random import time + import testValidation from testrunner import VdsmTestCase as TestCaseBase +from nose.plugins.skip import SkipTest from vdsm import vdscli
+try: + imp.find_module('mom') +except ImportError: + raise SkipTest('MOM is not installed')
class MOMTest(TestCaseBase):
@@ -37,7 +44,8 @@ (Host.Control "ksm_pages_to_scan" %d)""" % \ (run, pages_to_scan) s = vdscli.connect() - s.setMOMPolicy(testPolicyStr) + r = s.setMOMPolicy(testPolicyStr) + self.assertEqual(r['status']['code'], 0, str(r))
# Wait for the policy taking effect time.sleep(10)
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: momTest: improve test's error reports ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/749/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: momTest: improve test's error reports ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Thanks for the patch!
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: momTest: improve test's error reports ......................................................................
Patch Set 1:
had to fix my pep8 sins.
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: momTest: improve test's error reports ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/773/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Mark Wu has posted comments on this change.
Change subject: momTest: improve test's error reports ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
I didn't notice that :(
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: momTest: improve test's error reports ......................................................................
Patch Set 2: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: momTest: improve test's error reports ......................................................................
momTest: improve test's error reports
The test is skipped if MOM is not installed on host. Also, the returned value of the setMOMPolicy call is checked.
MOMTest.testKSM still fails on my host, but at least I can tell when in the test process it has happened.
Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/functional/momTests.py 1 file changed, 10 insertions(+), 1 deletion(-)
Approvals: Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7571 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If4298572eef9db20263ed00a603085b3830a7dbd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org