Alon Bar-Lev has uploaded a new change for review.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
BZ#849542 bootstrap: set system time as soon as possible
CURRENT BEHAVIOR
Set system time after installation.
NEW BEHAVIOR
Set system time at first stage. This makes the time difference between engine and host set to minimum.
Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vds_bootstrap/vds_bootstrap.py 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/7380/1
diff --git a/vds_bootstrap/vds_bootstrap.py b/vds_bootstrap/vds_bootstrap.py index 8211c81..537953d 100755 --- a/vds_bootstrap/vds_bootstrap.py +++ b/vds_bootstrap/vds_bootstrap.py @@ -868,6 +868,11 @@
oDeploy = Deploy()
+ if systime: + if not oDeploy.setSystemTime(systime): + logging.error('setSystemTime failed') + return False + if not oDeploy.checkRegistration(): logging.error('checkRegistration test failed') return False @@ -919,11 +924,6 @@ if firewallRulesFile: if not oDeploy.overrideFirewall(firewallRulesFile): logging.error('Failed to set default firewall') - return False - - if systime: - if not oDeploy.setSystemTime(systime): - logging.error('setSystemTime failed') return False
if not oDeploy.verifyServices():
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/562/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Alon Bar-Lev has posted comments on this change.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Juan Hernandez has posted comments on this change.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
Patch Set 1: Looks good to me, approved
makes a lot of sense. thanks.
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#849542 bootstrap: set system time as soon as possible ......................................................................
BZ#849542 bootstrap: set system time as soon as possible
CURRENT BEHAVIOR
Set system time after installation.
NEW BEHAVIOR
Set system time at first stage. This makes the time difference between engine and host set to minimum.
Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Signed-off-by: Alon Bar-Lev alonbl@redhat.com --- M vds_bootstrap/vds_bootstrap.py 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: Alon Bar-Lev: Verified Douglas Schilling Landgraf: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7380 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Juan Hernandez juan.hernandez@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org