From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support
......................................................................
Patch Set 30: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/72284/30/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
PS30, Line 271: int
I was expecting this to return an int.
you chose a list (/me does not know why) but the name of the function does not match.
Line 272: protocols = []
Line 273:
Line 274: for no_protocol in config.get('vars',
'ssl_protocol').split(','):
Line 275: if no_protocol != '':
Line 276: protocols.append(getattr(ssl, no_protocol.strip()))
in commit 181bca90e15e44ec you introduced ssl_protocol. if someone had used it, we should
not let them explode.
Line 277:
https://gerrit.ovirt.org/#/c/72284/30/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 629: from vdsm.sslutils import SSLContext
Line 630: sslctx = SSLContext(key_file=constants.KEY_FILE,
Line 631: cert_file=constants.CERT_FILE,
Line 632: ca_certs=constants.CA_FILE,
Line 633: protocol=CLIENT_PROTOCOL)
you've added this as a default, so why bother setting all the users?
Line 634: return StandAloneRpcClient(host, port, "jms.topic.vdsm_requests",
Line 635: str(uuid4()), sslctx, lazy_start=False)
Line 636:
Line 637:
--
To view, visit
https://gerrit.ovirt.org/72284
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes