Ayal Baron has posted comments on this change.
Change subject: Use SANLock lease offset when present
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(9 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 888: if not self.hasVolumeLeases():
s/hasVolumeLeases/supportVolumeLeases/
Line 889: return None, None
I don't think this logic belongs here.
getVolumeLease should just assume that this domain supports this capability or at least
raise a NotImplemented exception if not.
Line 897: leaseSlot = int(tag[blockVolume.TAG_PREXIX_LEN:])
PREXIX?
Line 902: # searching for the metadata offset.
At the risk of regretting this in the future when we actually need this, I don't think
we need this :)
Line 903: if tag.startswith(blockVolume.TAG_PREFIX_LEASE):
If you choose to keep this flow then:
]s/if/elif/
also add a test which goes through this code
Line 912: * self.logBlkSize * sd.LEASE_BLOCKS)
last part should be retrieved from sanlock
....................................................
File vdsm/storage/blockVolume.py
Line 41: # NOTE: create prefixes that are exactly TAG_PREXIX_LEN characters
s/PREXIX/PREFIX/
Line 48: # TAG_PREXIX_LEN is the length of the prefix strings used for the
s/PREXIX/PREFIX/
Line 50: TAG_PREXIX_LEN = 3
s/PREXIX/PREFIX/
--
To view, visit
http://gerrit.ovirt.org/2129
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27195f29efa691aadda0cac5afef55b04cc01658
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>