Saggi Mizrahi has submitted this change and it was merged.
Change subject: Don't subprocess for killall
......................................................................
Don't subprocess for killall
This is safer, quicker, removes one more subprocess call.
This also has the added benefit of giving us proper error codes so we
can differentiate between "no process found" and "failed to kill
process".
Change-Id: I035ed5f5eb3a2f3d4aadda83ddf0fc7dca07fd1a
---
M configure.ac
M vdsm/constants.py.in.in
M vdsm/storage/misc.py
M vdsm/storage/spm.py
4 files changed, 47 insertions(+), 20 deletions(-)
Approvals:
Saggi Mizrahi: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.usersys.redhat.com/804
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I035ed5f5eb3a2f3d4aadda83ddf0fc7dca07fd1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>