From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: handle incoming heartbeats
......................................................................
stomp: handle incoming heartbeats
According to stomp specification, Heart-beating can optionally be used
to test the healthiness of the underlying TCP connection and to make sure
that the remote end is alive and kicking. [1]
until now, we ignored incoming heartbeats and raised ValueError
when their value was not 0.
This patch gets the incoming heartbeats and updates the
dispatcher according to their value.
incoming heartbeat will be updated every time a new frame will be
received, indicating connection is still active.
If timeout has exceeded, the frame handler (client or server) will handle
it according to its implementation.
[1]
https://stomp.github.io/stomp-specification-1.2.html#Heart-beating
Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url:
https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompasyncdispatcher_test.py
2 files changed, 38 insertions(+), 7 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit
https://gerrit.ovirt.org/78218
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>