Federico Simoncelli has uploaded a new change for review.
Change subject: Revert "Avoid to activate parent volume on cloning" ......................................................................
Revert "Avoid to activate parent volume on cloning"
This reverts commit 8f5edaea39141cc6174dffce33108596a4643d1e.
Many volumes created with a previous VDSM version have a mismatch in the size advertised by the metadata and the virtual size defined in the the qcow2 header. At the moment the only solution is reverting to the hold behavior and propagate the mismatch (BZ#811880).
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 --- M vdsm/storage/volume.py 1 file changed, 13 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/4118/1 -- To view, visit http://gerrit.ovirt.org/4118 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Avoid to activate parent volume on cloning" ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 225: self.prepare(rw=False) do we really need to revert this part?
in order to make the base lv prepared for qemu-img?
-- To view, visit http://gerrit.ovirt.org/4118 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Avoid to activate parent volume on cloning" ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
I don't think we have a better choice at the moment.
-- To view, visit http://gerrit.ovirt.org/4118 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Revert "Avoid to activate parent volume on cloning" ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/storage/volume.py Line 225: self.prepare(rw=False) Yes, since we cannot provide the size, qemu-img needs to read it from the parent (and in the block domain case it must be prepared).
-- To view, visit http://gerrit.ovirt.org/4118 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Avoid to activate parent volume on cloning" ......................................................................
Patch Set 1: Verified; Looks good to me, approved
too bad, reverting until the corruption issue is assessed.
-- To view, visit http://gerrit.ovirt.org/4118 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "Avoid to activate parent volume on cloning" ......................................................................
Revert "Avoid to activate parent volume on cloning"
This reverts commit 8f5edaea39141cc6174dffce33108596a4643d1e.
Many volumes created with a previous VDSM version have a mismatch in the size advertised by the metadata and the virtual size defined in the the qcow2 header. At the moment the only solution is reverting to the hold behavior and propagate the mismatch (BZ#811880).
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 --- M vdsm/storage/volume.py 1 file changed, 13 insertions(+), 15 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/4118 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Ie2ab9a2a2979f8880a45acaa3075e8d208d668a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org