Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: removeBridge(): Add skipLibvirt validation ......................................................................
removeBridge(): Add skipLibvirt validation
Do not check if bridge is listed in libvirt in case of using skipLibvirt. Introduced by: 1a24550b968ca48bb808e263368743f4c91adde4
Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com --- M vdsm/configNetwork.py 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/3941/1 -- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: removeBridge(): Add skipLibvirt validation ......................................................................
Patch Set 1: Fails; I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/configNetwork.py Line 325: if not utils.tobool(options.get('skipLibvirt', False)): "options" not defined in this function!
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2: I would prefer that you didn't submit this
I cannot say that I'm happy with this approach. skipLibvirt was a hasty hack, introduced for the bootstrapping use case. it should NOT become so prevalent in the code.
addNetwork and delNetwork must be capable of handling bridges that were added outside of Vdsm.
What is exactly the scenario trigerring the error (yes, I know networking is terribly broken atm)
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2:
Hi Dan,
I cannot say that I'm happy with this approach. skipLibvirt was a hasty hack, introduced for the bootstrapping use case. it should NOT become so prevalent in the code addNetwork and delNetwork must be capable of handling bridges that were added outside of Vdsm.
Agreed.
What is exactly the scenario trigerring the error (yes, I know networking is terribly broken atm)
Executing AutoInstall.
Boot oVirt Node CD and press tab to pass arguments, add to grub:
storage_init=/dev/sda BOOTIF=eth0 adminpw=RHhwCLrQXB8zE
Note: the password RHhwCLrQXB8zE is 'redhat'
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2:
how about starting libvirt before using these functions?
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2:
Hi Dan,
how about starting libvirt before using these functions?
Sounds good to me, I have remembered my previous patch:
http://gerrit.ovirt.org/#patch,sidebyside,3615,1,vdsm_reg/deployUtil.py.in
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has abandoned this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2: Abandoned
Commit: ea844bd288c533e4675404d2ca5e0ec58f23ca42 and f5bf747a354eb5faa251acd22ad499a5ff17aafd resolves the problem.
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has abandoned this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2: Restored
The error still exists.. probably in the past I did a wrong test. Back to the code.
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Douglas Schilling Landgraf has abandoned this change.
Change subject: configNetwork: additional skipLibvirt ......................................................................
Patch Set 2: Abandoned
Indeed, this patch is not required. Let's avoid the skipLibvirt.
-- To view, visit http://gerrit.ovirt.org/3941 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I0874843afe3d4189bff63ddd4bb05ebd29e7cb54 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org