Igor Lvovsky has uploaded a new change for review.
Change subject: (WIP) BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
(WIP) BZ#832765 - Rewrite vdsm-restore-net-config as python module
Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/Makefile.am A vdsm/vdsm-restore-net-config D vdsm/vdsm-restore-net-config.in M vdsm/vdsmd.init.in 4 files changed, 50 insertions(+), 53 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/6991/1 -- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
minor comments
.................................................... File vdsm/vdsmd.init.in Line 499: python @VDSMDIR@/vdsm-restore-net-config do we really need this change? why not make the new script executable just like the former one?
.................................................... File vdsm/vdsm-restore-net-config Line 39: # Remove restored backups I love comments. But I think the function names are clear enough, and here the comments only clutter the code.
Line 48: sys.exit(e.errCode) does anyone care about the specific error code here? are we sure it's even in the 0-127 range? I'd drop the whole try:except clause.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 2:
and something more serious: nothing here makes sure that the network devices are re-created properly.
I do not see a proper solution aside of taking down all relevant devices before the removal, and taking them up again after it.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 3:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests/947/
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests/947/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 3: (1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 47: sys.exit(0) that's the default, I believe.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 4:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/281/
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 5:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/282/
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/282/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 5: Verified
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
.................................................... File vdsm/vdsm-restore-net-config Line 22: import sys please drop this like and add the sctipt to PYFLAKES
Line 32: def main(): please add newline and add the sctipt to PEP8WHITELIST
Line 41: subprocess.Popen(['/etc/init.d/network', 'stop'], we should not stop networking unless *something* was loaded.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/416/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 6: Looks good to me, approved
it looks lovely. really.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/428/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
Indeed, very nice patch. I am adding -1 since I have a question.
.................................................... File vdsm/vdsm-restore-net-config Line 26: Line 27: def main(): Line 28: # this should NOT be used in ovirt-node, where configuration persistence is Line 29: # handled otherwise. Line 30: if os.path.exists('/etc/rhev-hypervisor-release'): I guess you are looking for /etc/ovirt-node-iso-release Line 31: return Line 32: Line 33: configWriter = configNetwork.ConfigWriter() Line 34: configWriter.loadBackups()
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 7: (1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 26: Line 27: def main(): Line 28: # this should NOT be used in ovirt-node, where configuration persistence is Line 29: # handled otherwise. Line 30: if os.path.exists('/etc/rhev-hypervisor-release'): I use /etc/rhev-hypervisor-release because it was used in bash version. Is it wrong? So how it worked before? Line 31: return Line 32: Line 33: configWriter = configNetwork.ConfigWriter() Line 34: configWriter.loadBackups()
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 7: (1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 26: Line 27: def main(): Line 28: # this should NOT be used in ovirt-node, where configuration persistence is Line 29: # handled otherwise. Line 30: if os.path.exists('/etc/rhev-hypervisor-release'): bash version? Sorry, I didn't get it.
on oVirt Node TUI, pressed F2 -> shell
# ls /etc/rhev* ls: cannot access /etc/rhev*: No such file or directory
# cat /etc/ovirt-node-iso-release oVirt Node Hypervisor release 2.5.0 (2.0.fc17) Line 31: return Line 32: Line 33: configWriter = configNetwork.ConfigWriter() Line 34: configWriter.loadBackups()
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Michael Burns has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 26: Line 27: def main(): Line 28: # this should NOT be used in ovirt-node, where configuration persistence is Line 29: # handled otherwise. Line 30: if os.path.exists('/etc/rhev-hypervisor-release'): for upstream ovirt-node, it's always ovirt-node-iso-release or ovirt-node-image-release. For RHEV-H builds, it's rhev-hypervisor-release
For this check, there is an isOvirt function somewhere that should work already. Line 31: return Line 32: Line 33: configWriter = configNetwork.ConfigWriter() Line 34: configWriter.loadBackups()
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 8: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Michael Burns has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9: (1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 29: # this should NOT be used in ovirt-node, where configuration persistence is Line 30: # handled otherwise. Line 31: try: Line 32: if os.path.exists('/etc/rhev-hypervisor-release') or \ Line 33: not len(glob.glob('/etc/ovirt-node-*-release')) == 0: this will probably work, but why not use isOvirt from deployUtil.py (or relocate the function into a common place and use it from there? Line 34: return Line 35: except: Line 36: pass Line 37:
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Igor Lvovsky has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9: (1 inline comment)
.................................................... File vdsm/vdsm-restore-net-config Line 29: # this should NOT be used in ovirt-node, where configuration persistence is Line 30: # handled otherwise. Line 31: try: Line 32: if os.path.exists('/etc/rhev-hypervisor-release') or \ Line 33: not len(glob.glob('/etc/ovirt-node-*-release')) == 0: unfortunately we already have this check in several different places in vdsm (except deployUtil) and you are absolutely right, it will be good to gather it in some common place (we already spoke with Dan about it)
I just don't want to mix it with this patch series, it's a long series that fix network's rollback. But, we will do it in different patch Line 34: return Line 35: except: Line 36: pass Line 37:
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/455/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Meni Yakove has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9: Verified
https://engineering.redhat.com/trac/preint/ticket/749
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9: Looks good to me, but someone else must approve
Agreed, we will require a common place soon.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9: Fails
please do not submit before fixing the unit tests.
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 9:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/461/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 10:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/486/ : FAILURE
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 10:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_create_rpms_f17/16/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 10: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
Patch Set 10: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module ......................................................................
BZ#832765 - Rewrite vdsm-restore-net-config as python module
Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/Makefile.am A vdsm/vdsm-restore-net-config D vdsm/vdsm-restore-net-config.in 3 files changed, 46 insertions(+), 52 deletions(-)
Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6991 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Michael Burns mburns@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org