From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: network: report dpdk ports as nics ......................................................................
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/73987/10/lib/vdsm/network/ipwrapper.py File lib/vdsm/network/ipwrapper.py:
PS10, Line 277: getLinks this function is not tested yet, but the Right Thing to do is to add a test for it.
https://gerrit.ovirt.org/#/c/73987/10/lib/vdsm/network/link/dpdk.py File lib/vdsm/network/link/dpdk.py:
Line 52: Line 53: Line 54: def link_info(dpdk_link): Line 55: """Returns a dictionary with the information of the link object.""" Line 56: info = {} to repeat Eddy's comment:
info = { 'address': _get_hw_addr(dpdk_link), 'flags': '', 'index': '', ... }
is more compact Line 57: info['address'] = _get_hw_addr(dpdk_link) Line 58: info['flags'] = '' Line 59: info['index'] = '' Line 60: info['mtu'] = ''
https://gerrit.ovirt.org/#/c/73987/10/lib/vdsm/network/netinfo/cache.py File lib/vdsm/network/netinfo/cache.py:
PS10, Line 106: dev.isDPDK() frankly, testing
if dev.name in dpdk_devices
is safer than isDPDK()'s implementation, and probably a bit faster.
vdsm-patches@lists.fedorahosted.org