Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond ......................................................................
BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond
Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/7464/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 0dc5f34..1c69294 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -1117,6 +1117,12 @@ bridge = brNets[0] if brNets else None
if bond in _netinfo.bondings: + # Save MTU for future set on NICs + confParams = netinfo.getIfaceCfg(bond) + mtu = confParams.get('MTU', None) + if mtu: + mtu = int(mtu) + ifdown(bond) # Take down all bond's NICs. for nic in _netinfo.getNicsForBonding(bond): @@ -1130,11 +1136,11 @@ # Anyway, we will not be able to take it down with connected VMs
# First we need to prepare all conf files - configWriter.addBonding(bond, bridge=bridge, + configWriter.addBonding(bond, bridge=bridge, mtu=mtu, bondingOptions=bondAttrs.get('options', None))
for nic in bondAttrs['nics']: - configWriter.addNic(nic, bonding=bond) + configWriter.addNic(nic, bonding=bond, mtu=mtu)
# Now we can run ifup for all interfaces ifup(bond)
-- To view, visit http://gerrit.ovirt.org/7464 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7464 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/668/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7464 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Meni Yakove has posted comments on this change.
Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond ......................................................................
Patch Set 2: Verified
https://bugzilla.redhat.com/show_bug.cgi?id=846312
-- To view, visit http://gerrit.ovirt.org/7464 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond ......................................................................
BZ#846312 - Keep MTU on ehtX after bond editing, when ethX part of this bond
Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 9 insertions(+), 2 deletions(-)
Approvals: Meni Yakove: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/7464 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: Iffba66b245f924e88e1c89caa71c5d3cb15b77be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org