From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hugepages: add support for shared pages
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/77808/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line 420: conv.tobool
We should not use this evil tobool, if the input is not a bool, we
should e
the value of custom properties is always a string, Engine can never send a
bool. Maybe you suggest that we are stricter here
if custom.get('hugepages_shared') == 'True':
hugepages_shared = True
elif ('False', None)
hugepages_hsared = False
else: raise ValueError
I find this pile of code a bit ugly, and don't mind being a bit more flexible when it
comes to human-typed values.
--
To view, visit
https://gerrit.ovirt.org/77808
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0eb7b20a16e3e4a0d57da02ff7490136071dd8f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes