Mark Wu has posted comments on this change.
Change subject: Collect more guest memory stats
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/guestIF.py
Line 104: # 'mem_total', 'mem_free', 'mem_unused',
'swap_in', 'swap_out',
mem_unused represents the memory is free totally, not in any use.
mem_free is the sum of 'mem_unused' and the amount of cache/buffer pages.
Because kernel will reclaim the cache/buffer pages under low memory available, so that
portion is also available from the point of view of application. I admit it's
confusing, but it comes from the system memory management, not the ovirt-guest-agent
patch.
Line 111: v = _filterXmlChars(str(v))
I learned it from the 'disks-usage' message handling code.
disk['total'] = _filterXmlChars(str(disk['total']))
All the values in 'memory-stat' are numbers, so I think that should be ok to use
str() here.
--
To view, visit
http://gerrit.ovirt.org/3917
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I678210dac8c66eeb0360e58e5332de3218402463
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>