Dan Kenigsberg has posted comments on this change.
Change subject: Add libvirt password as config file
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirt_password
Line -3
Line -2
Line -1
Line 0
Line 1: shibboleth
this has newline, which means a changed password.
Line 2
Line 3
Line 4
Line 5
....................................................
File vdsm.spec.in
Line 135: rm -f /etc/init/libvirtd.conf
Line 136:
Line 137: /sbin/chkconfig libvirtd on
Line 138: /sbin/service libvirtd start >/dev/null
Line 139: fi
it would be nicer to delete the saslpasswd here.
Line 140: fi
Line 141:
Line 142: %postun
Line 143: if [ "$1" -ge 1 ]; then
--
To view, visit
http://gerrit.usersys.redhat.com/1052
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d2ac1f9d558840dd0ac511db5bde0bac32c2b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>