Ryan Harper has uploaded a new change for review.
Change subject: PEP8 fixes for localFsSD ......................................................................
PEP8 fixes for localFsSD
% pep8 vdsm/storage/localFsSD.py vdsm/storage/localFsSD.py:16:80: E501 line too long (80 characters) vdsm/storage/localFsSD.py:49:80: E501 line too long (84 characters) vdsm/storage/localFsSD.py:102:1: E302 expected 2 blank lines, found 1
Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Signed-off-by: Ryan Harper ryanh@us.ibm.com --- M vdsm/storage/localFsSD.py 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/3938/1 -- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 1: I would prefer that you didn't submit this
please add to PEP8_WHITELIST so no one ever breaks this cleaning.
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Adam Litke has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 2: No score; I would prefer that you didn't submit this
please rebase...
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Ryan Harper has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 3: Verified
Verified rpm build and install. No behavioral changes found.
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Adam Litke has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Wenyi Gao has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: PEP8 fixes for localFsSD ......................................................................
Patch Set 3: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: PEP8 fixes for localFsSD ......................................................................
PEP8 fixes for localFsSD
% pep8 vdsm/storage/localFsSD.py vdsm/storage/localFsSD.py:16:80: E501 line too long (80 characters) vdsm/storage/localFsSD.py:49:80: E501 line too long (84 characters) vdsm/storage/localFsSD.py:102:1: E302 expected 2 blank lines, found 1
Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Signed-off-by: Ryan Harper ryanh@us.ibm.com --- M Makefile.am M vdsm/storage/localFsSD.py 2 files changed, 5 insertions(+), 2 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Ryan Harper: Verified Ewoud Kohl van Wijngaarden: Verified; Looks good to me, but someone else must approve Wenyi Gao: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/3938 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I7ec53b45fc27b48d21638e405b219a66f2707b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Wenyi Gao wenyi@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org