Nir Soffer has uploaded a new change for review.
Change subject: api: Make remove optional
......................................................................
api: Make remove optional
According to the scheama, the "remove" argument in
StoragePool.disconnect is optional, but in API it is defined as
positional argument and requires a value.
This error was probbaly hidden by the fact that engine send False when
using xmlprc. But when using jsonrpc the this cause the method to call
to fail, which eventually cause host to be stuck in "Unassigned" state
in the engine side. This fix the error on the vdsm side.
Change-Id: Ia6948e4fd1ddefd7e33406a214f0cbfe301c958b
Bug-Url:
https://bugzilla.redhat.com/1115033
Relates-to:
https://bugzilla.redhat.com/1115044
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/29465/1
diff --git a/vdsm/API.py b/vdsm/API.py
index e739294..ace68d1 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1034,7 +1034,7 @@
def destroy(self, hostID, deprecatedSCSIKey):
return self._irs.destroyStoragePool(self._UUID, hostID)
- def disconnect(self, hostID, deprecatedSCSIKey, remove):
+ def disconnect(self, hostID, deprecatedSCSIKey, remove=False):
return self._irs.disconnectStoragePool(self._UUID, hostID, remove)
def disconnectStorageServer(self, domainType, connectionParams):
--
To view, visit
http://gerrit.ovirt.org/29465
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6948e4fd1ddefd7e33406a214f0cbfe301c958b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>