From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Extract common requirements from condition
......................................................................
spec: Extract common requirements from condition
Over time, the spec file developed duplicate requirements in
different branches of conditions:
%if 0%{rhel}
Requires: some-package
%else
Require: some-package
%endif
This has no merit, and just makes the spec file harder to maintain.
This patch extracts these commonalities so they can be maintained in a
single place.
If any specific platform needs to introduce a specific version
requirement (Requires: some-package > 1.2.3), that package can always be
moved back to the condition.
Change-Id: Ib5608194f86fe3f5808433f17d28b8163150967b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/68949
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5608194f86fe3f5808433f17d28b8163150967b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>