Nir Soffer has submitted this change and it was merged.
Change subject: xmlrpc: Hide fenceNode password in the log
......................................................................
xmlrpc: Hide fenceNode password in the log
We enabled logging of fenceNode xmlrpc calls, however there is a
plain password in the call parameters. This patch prevents the password
from being written to the log.
Password logging seems to be already handled with jsonrpc, so this patch
just fixes xmlrpc.
Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5
Backport-To: 4.0
Backport-To: 3.6
Bug-Url:
https://bugzilla.redhat.com/1339291
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/58833
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/rpc/bindingxmlrpc.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Milan Zamazal: Verified
--
To view, visit
https://gerrit.ovirt.org/58833
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53318ed8ce425f042b5f783af779b540c1dfd7b5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt(a)midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>