Dan Kenigsberg has posted comments on this change.
Change subject: BZ#741658 Move VM to Down if libvirt reports VIR_ERR_NO_DOMAIN ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/utils.py Line 390: statsFunction() Line 391: except Exception, e: Line 392: if not self.handleStatsException(e): Line 393: self._log.error("Stats function failed: %s", Line 394: statsFunction, exc_info=True) did you mean to re-raise the exception if not handled? Line 395: Line 396: self._stopEvent.wait(waitInterval) Line 397: intervalAccum = (intervalAccum + waitInterval) % maxInterval Line 398:
-- To view, visit http://gerrit.usersys.redhat.com/984 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id6262fb2504534c56fdec246937423d629f92e13 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
vdsm-patches@lists.fedorahosted.org