Hello Roy Golan, Omer Frenkel,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: BZ#847744 fenceNode API is missing the options argument ......................................................................
BZ#847744 fenceNode API is missing the options argument
Yes, ovirt-3.1 is happily released by now, but I find this bug so devastating, that I would like us to consider a follow-up build of vdsm.
Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Signed-off-by: Roy Golan rgolan@redhat.com Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: http://gerrit.ovirt.org/7058 Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-by: Omer Frenkel ofrenkel@redhat.com Tested-by: Omer Frenkel ofrenkel@redhat.com --- M vdsm/BindingXMLRPC.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/7145/1
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py index 7c65e6a..e1a61f1 100644 --- a/vdsm/BindingXMLRPC.py +++ b/vdsm/BindingXMLRPC.py @@ -352,7 +352,7 @@ secure=False, options=''): api = API.Global(self.cif) return api.fenceNode(addr, port, agent, username, password, - action, secure) + action, secure, options)
def setLogLevel(self, level): api = API.Global(self.cif)
-- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#847744 fenceNode API is missing the options argument ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/430/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Roy Golan has posted comments on this change.
Change subject: BZ#847744 fenceNode API is missing the options argument ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Roy Golan has posted comments on this change.
Change subject: BZ#847744 fenceNode API is missing the options argument ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has abandoned this change.
Change subject: BZ#847744 fenceNode API is missing the options argument ......................................................................
Patch Set 1: Abandoned
I suppose it is too late for fixing the past ovirt-3.1. See you in 3.2.
-- To view, visit http://gerrit.ovirt.org/7145 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.1 Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Omer Frenkel ofrenkel@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org