Igor Lvovsky has uploaded a new change for review.
Change subject: Add atomic/persist backup capabilities for logical networks ......................................................................
Add atomic/persist backup capabilities for logical networks
Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/6913/1 -- To view, visit http://gerrit.ovirt.org/6913 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add atomic/persist backup capabilities for logical networks ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
I think we can define a helper function
def writeBackupFile(dirName, fileName, content)
.................................................... File vdsm/configNetwork.py Line 217: logging.debug('failed to get libvirt network %s', netName, please remove this logging line. it only adds log news, as the exception is re-raised.
Line 239: backup = os.path.join(netinfo.NET_LOGICALNET_CONF_BACK_DIR, network) you are correct - this should better be factored out into a separate function, used by _persistentBackup(), too.
-- To view, visit http://gerrit.ovirt.org/6913 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add atomic/persist backup capabilities for logical networks ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/configNetwork.py Line 298: content = open().read(filename) ahm...
this should be
content = open(filename).read()
-- To view, visit http://gerrit.ovirt.org/6913 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Add atomic/persist backup capabilities for logical networks ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/configNetwork.py Line 298: content = open().read(filename) oops
-- To view, visit http://gerrit.ovirt.org/6913 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Add atomic/persist backup capabilities for logical networks ......................................................................
Patch Set 3: Looks good to me, approved
can we somehow add tests for the new functions? ain't gonna be easy.
-- To view, visit http://gerrit.ovirt.org/6913 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add atomic/persist backup capabilities for logical networks ......................................................................
Add atomic/persist backup capabilities for logical networks
Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Signed-off-by: Igor Lvovsky ilvovsky@redhat.com --- M vdsm/configNetwork.py 1 file changed, 66 insertions(+), 18 deletions(-)
Approvals: oVirt Jenkins CI Server: Verified Dan Kenigsberg: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/6913 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org