Dan Kenigsberg has posted comments on this change.
Change subject: sp: prevent master demotion on activation
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/28332/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 1041:
Line 1042: # Domain conversion requires the links to be present
Line 1043: self._refreshDomainLinks(dom)
Line 1044:
Line 1045: # This should never happen because we're not deactivating the
Why should we comply with misguided request of Engine? It's safer to return an error
and give Engine the opportunity to correct its ways.
I am guessing that this is what happens currently - the master domain demotior would cause
the spm to drop its role, and a new master domain would have to be reconstructed.
Line 1046: # current master in deactivateStorageDomain if a new master is
Line 1047: # not provided. It is also impossible to connect to a pool
Line 1048: # where the master domain is not active. Anyway to be on the
Line 1049: # safe side we must prevent the current master domain from
--
To view, visit
http://gerrit.ovirt.org/28332
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47a0c3ea16bcdefa99899e04c453eaf995344dfb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes